Skip to content

Use testFixtures #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

Use testFixtures #154

merged 1 commit into from
Nov 4, 2024

Conversation

pboos
Copy link
Contributor

@pboos pboos commented Nov 4, 2024 •
edited
Loading

Use test fixtures to not expose test related code and dependencies outside of test.

@pboos pboos marked this pull request as ready for review November 4, 2024 14:16
@pboos pboos requested a review from a team as a code owner November 4, 2024 14:16
@pboos pboos requested a review from huguenin November 4, 2024 14:16
eleonoraborghi
eleonoraborghi approved these changes Nov 4, 2024
View reviewed changes
Copy link

@eleonoraborghi eleonoraborghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@pboos pboos merged commit 6f781d6 into main Nov 4, 2024
3 checks passed
@pboos pboos deleted the testFixtures branch November 4, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huguenin huguenin Awaiting requested review from huguenin huguenin is a code owner automatically assigned from getyourguide/chk

1 more reviewer

@eleonoraborghi eleonoraborghi eleonoraborghi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pboos @eleonoraborghi